Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: Update all tests which depend on editor #6738

Merged
merged 1 commit into from
May 21, 2018
Merged

Blocks: Update all tests which depend on editor #6738

merged 1 commit into from
May 21, 2018

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented May 14, 2018

Description

Follow up for #6731. An alternative solution to #6730.

This PR removes the dependency on the editor module code from blocks tests. To accomplish that I updated all tests to work without all editor hooks applied. I moved also tests related to InnerBlocks component to be located next to the source code. Finally, I moved code that tests multiple hooks applied to the newly introduced integration folder.

How has this been tested?

npm test

Types of changes

Refactoring for tests, no production code changed.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.

@gziolo gziolo added [Feature] Blocks Overall functionality of blocks [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels May 14, 2018
@gziolo gziolo self-assigned this May 14, 2018
@gziolo gziolo requested review from youknowriad and a team May 14, 2018 13:30
youknowriad
youknowriad approved these changes May 21, 2018
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gziolo gziolo merged commit 67bf325 into master May 21, 2018
@gziolo gziolo deleted the update/blocks-tests-no-editor-deps branch May 21, 2018 09:20
@mtias mtias added this to the 3.0 milestone Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

Assignees

@gziolo gziolo

Labels
[Feature] Blocks Overall functionality of blocks [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gziolo @youknowriad @mtias